Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanups #3384

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Small cleanups #3384

merged 3 commits into from
Jun 1, 2023

Conversation

romac
Copy link
Member

@romac romac commented May 31, 2023

No description provided.

@romac romac requested a review from ljoss17 May 31, 2023 16:21
@seanchen1991
Copy link
Contributor

Is this ready for merging?

@romac
Copy link
Member Author

romac commented May 31, 2023

Yes!

@seanchen1991
Copy link
Contributor

Let's get this change in here. Then it looks good to me 👍

@seanchen1991
Copy link
Contributor

Oh never mind, just realized that PR that introduced the max_concurrency parameter was merged into the romac/remove_runtime branch.

@romac romac merged commit 15449cc into master Jun 1, 2023
@romac romac deleted the romac/cleanup branch June 1, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 approved these changes

@ljoss17 ljoss17 Awaiting requested review from ljoss17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @seanchen1991